From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches Date: Fri, 14 Sep 2018 16:50:24 +0200 Message-ID: <6831653.AvvoQPlBBt@xps> References: <20180815153346.11495-1-i.maximets@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ilya Maximets , dev@dpdk.org, Stephen Hemminger To: Arnon Warshavsky Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 25A6A4F98 for ; Fri, 14 Sep 2018 16:50:31 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/08/2018 07:25, Arnon Warshavsky: > Hi Ilya > > Let's use single quotes instead of variable. > > > Using the script directly with single quotes loses the ability to reuse it > with an additional set of folders , expressions and RET_ON_FAIL. I don't know awk. Please could you explain what we are loosing and why? > If we wish to keep the awk code in this file and not in a separate file, > maybe receiving the awk script parameters from the function > check_forbidden_additions( ) can also preserve the ability to reuse in > future cases. Yes I feel we could add some parameters to this function. And yes, we could move the awk script in a separate file. Actually, it would be better to keep checkpatches.sh as a wrapper script calling various tools. Thanks