Re: [PATCH v5 20/35] net/intel: write descriptors using non-volatile pointers

Bruce Richardson
2026-02-12T08:43:35Z

On Wed, Feb 11, 2026 at 10:14:20PM +0100, Morten Brørup wrote:
> > +static inline void
> > +write_txd(volatile void *txd, uint64_t qw0, uint64_t qw1)
> > +{
> > + /* we use an aligned structure and cast away the volatile to
> > allow the compiler
> > + * to opportunistically optimize the two 64-bit writes as a
> > single 128-bit write.
> > + */
> > + __rte_aligned(16) struct txdesc {
> > + uint64_t qw0, qw1;
>
> The documentation for __rte_aligned() says [1] it must be between the "struct" keyword and the name of the structure.
> I.e. it should be:
> struct __rte_aligned(16) txdesc {
>
Thanks. I should read the docs more! If no other patches need rework, I'll
just fix this on apply.

/Bruce