Re: [PATCH v4 26/35] net/intel: drop unused Tx queue used count

Burakov, Anatoly
2026-02-10T14:14:44Z

On 2/9/2026 5:45 PM, Bruce Richardson wrote:
> Since drivers now track the setting of the RS bit based on fixed
> thresholds rather than after a fixed number of descriptors, we no longer
> need to track the number of descriptors used from one call to another.
> Therefore we can remove the tx_used value in the Tx queue structure.
>
> This value was still being used inside the IDPF splitq scalar code,
> however, the ipdf driver-specific section of the Tx queue structure also
> had an rs_compl_count value that was only used for the vector code
> paths, so we can use it to replace the old tx_used value in the scalar
> path.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

> txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_EOP;
>
> txq->nb_tx_free = (uint16_t)(txq->nb_tx_free - nb_used);
> - txq->nb_tx_used = (uint16_t)(txq->nb_tx_used + nb_used);
> + txq->rs_compl_count += nb_used;
>
> - if (txq->nb_tx_used >= 32) {
> + if (txq->rs_compl_count >= 32) {

Should 32 perpahs be a macro?

> txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_RE;
> /* Update txq RE bit counters */
> - txq->nb_tx_used = 0;
> + txq->rs_compl_count = 0;
> }
> }
>

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

--
Thanks,
Anatoly