From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal/ppc: fix compilation error with a broken else clause Date: Tue, 30 Jan 2018 14:46:04 +0100 Message-ID: <6873526.vGmRUKyOO2@xps> References: <0d242c92a3734252f6baa5592c56afeba254941b.1517301739.git.gowrishankar.m@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Chao Zhu , Olivier Matz To: Gowrishankar Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F0EFD1B418 for ; Tue, 30 Jan 2018 14:46:50 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/01/2018 11:53, Gowrishankar: > From: Gowrishankar Muthukrishnan > > Calling rte_smp_{w/r}mb macro expands into a compound block, which > would break compiling a else clause following it, if that calling > place has been terminated already with ";", as in below code. > This patch adds { } around this macro to allow compiling else too. > > Fixes: d23a6bd04d ("eal/ppc: fix memory barrier for IBM POWER") > Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power") > > Signed-off-by: Gowrishankar Muthukrishnan Applied, thanks