From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: added new `rte_lcore_is_service_lcore` API. Date: Fri, 15 Sep 2017 17:51:36 +0200 Message-ID: <6875069.BRSTqJL15t@xps> References: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com> <20170915145933.GA16776@PBHAGAVATULA-LT> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Van Haaren, Harry" , dev@dpdk.org To: Pavan Nikhilesh Bhagavatula Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 29D3025E5 for ; Fri, 15 Sep 2017 17:51:38 +0200 (CEST) In-Reply-To: <20170915145933.GA16776@PBHAGAVATULA-LT> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2017 16:59, Pavan Nikhilesh Bhagavatula: > On Fri, Sep 15, 2017 at 02:44:57PM +0000, Van Haaren, Harry wrote: > > > > > We could also choose to add this function to rte_service.h ? > > > > > > > > Yes that is an option, and OK with me. > > > > > > > > @Pavan what do you think of adding it to service.h, implement in .c and add > > > to .map? > > > > > > > > > > The ROLE_SERVICE/ROLE_RTE defines the role of a lcore so it made sense to put > > > it in rte_lcore.h as lcore properties are accessed mostly through this header. > > > I'm fine with adding it to service.h as suggested by Harry. > > > > > > -Pavan > > > > *as suggested by Thomas ;) > > > > Initially I thought it made more sense in lcore.h too, however the application > > should only require knowing if core X is a service core if it cares about > > services / service-cores, hence I'm fine with rte_service.h too. > > > > -Harry > > > Agreed, will spin up a v2. The most difficult is to find a good name for this function :)