From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous Date: Fri, 4 May 2018 10:29:57 +0100 Message-ID: <68d1bc7b-a90d-2adc-c98b-560276589b15@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Thomas Monjalon , stable@dpdk.org To: Gowrishankar , Sergio Gonzalez Monroy Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03-May-18 11:11 AM, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > During malloc heap init, if there are malloc_elems contiguous in > virt addresses, they could be merged so that, merged malloc_elem > would guarantee larger free memory size than its actual hugepage > size, it was created for. > > Fixes: fafcc11985 ("mem: rework memzone to be allocated by malloc") > Cc: stable@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan > --- Hi Gowrishankar, I haven't looked at the patchset in detail yet, however i have a general question: how do we end up with VA-contiguous memsegs that are not part of the same memseg in the first place? Is there something wrong with memseg sorting code? Alternatively, if they were broken up, presumably they were broken up for a reason, namely while they may be VA contiguous, they weren't IOVA-contiguous. Can you provide a dump of physmem layout where memory would have been VA and IOVA-contiguous while belonging to different memsegs? -- Thanks, Anatoly