From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH] cryptodev: fix session init return value
Date: Tue, 25 Jul 2017 14:03:27 +0530
Message-ID: <6905df02-6f11-a53e-f5cb-24498007a530@nxp.com>
References: <20170724085428.51995-1-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 <zbigniew.bodek@caviumnetworks.com>, <jerin.jacob@caviumnetworks.com>,
 <hemant.agrawal@nxp.com>, <fiona.trahe@intel.com>, <deepak.k.jain@intel.com>,
 <john.griffin@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0051.outbound.protection.outlook.com [104.47.38.51])
 by dpdk.org (Postfix) with ESMTP id C61C52C16
 for <dev@dpdk.org>; Tue, 25 Jul 2017 10:33:42 +0200 (CEST)
In-Reply-To: <20170724085428.51995-1-pablo.de.lara.guarch@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/24/2017 2:24 PM, Pablo de Lara wrote:
> When calling rte_cryptodev_sym_session_init(),
> if there was an error, it returned -1, regardless
> the error.
> Instead, it should return the specific error code, which can
> be valuable for the application for error handling.
> 
> Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>   drivers/crypto/aesni_gcm/aesni_gcm_pmd.c       |   8 +-
>   drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c   |  12 +-
>   drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c     |  30 +++--
>   drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c |  12 +-
>   drivers/crypto/armv8/rte_armv8_pmd.c           |  14 +--
>   drivers/crypto/armv8/rte_armv8_pmd_ops.c       |  10 +-
>   drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c    |  10 +-
>   drivers/crypto/kasumi/rte_kasumi_pmd.c         |   6 +-
>   drivers/crypto/kasumi/rte_kasumi_pmd_ops.c     |  10 +-
>   drivers/crypto/null/null_crypto_pmd.c          |   4 +-
>   drivers/crypto/null/null_crypto_pmd_ops.c      |  10 +-
>   drivers/crypto/openssl/rte_openssl_pmd.c       |  24 ++--
>   drivers/crypto/openssl/rte_openssl_pmd_ops.c   |  11 +-
>   drivers/crypto/qat/qat_crypto.c                | 162 +++++++++++++++----------
>   drivers/crypto/scheduler/scheduler_pmd_ops.c   |   8 +-
>   drivers/crypto/snow3g/rte_snow3g_pmd.c         |   6 +-
>   drivers/crypto/snow3g/rte_snow3g_pmd_ops.c     |  10 +-
>   drivers/crypto/zuc/rte_zuc_pmd.c               |   6 +-
>   drivers/crypto/zuc/rte_zuc_pmd_ops.c           |  10 +-
>   lib/librte_cryptodev/rte_cryptodev.c           |   8 +-
>   lib/librte_cryptodev/rte_cryptodev.h           |   4 +-
>   lib/librte_cryptodev/rte_cryptodev_pmd.h       |   4 +-
>   test/test/test_cryptodev.c                     |   4 +-
>   23 files changed, 222 insertions(+), 161 deletions(-)
> 

Acked for dpaa2_sec, librte_cryptodev, test