From: Raslan Darawsheh <rasland@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Maayan Kashani <mkashani@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix default flow engine on Windows
Date: Tue, 10 Mar 2026 11:44:35 +0200 [thread overview]
Message-ID: <69146d37-61af-4ca8-af57-3e1267c31241@nvidia.com> (raw)
In-Reply-To: <20260309124754.226628-1-dsosnowski@nvidia.com>
Hi,
On 09/03/2026 2:47 PM, Dariusz Sosnowski wrote:
> Offending patch has changed the logic for handling default
> configuration for dv_flow_en device argument.
> This change has introduced a regression to Windows support.
> On Windows, mlx5 PMD only supports flow API implementation
> with dv_flow_en set to 1. With the change, this argument value was
> changed based on device capabilities.
> On newer NICs, dv_flow_en would be set to HW Steering flow engine
> which is not supported on Windows.
> On older NICs, it would be set to Verbs engine, which is also not
> supported.
>
> This patch fixes that by introducing platform-specific initialization
> and fixup of relevant device arguments i.e., dv_flow_en and
> allow_duplicate_pattern.
> On Linux the existing logic is kept. On Windows dv_flow_en and
> allow_duplicate_pattern are set by default to 1 (same as before
> the offending patch).
>
> Fixes: 170ebe941be3 ("net/mlx5: fix flow devargs handling for future HW")
>
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Bing Zhao <bingz@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2026-03-10 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 12:47 [PATCH] net/mlx5: fix default flow engine on Windows Dariusz Sosnowski
2026-03-10 9:44 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69146d37-61af-4ca8-af57-3e1267c31241@nvidia.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox