From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix examples build failure Date: Mon, 08 Feb 2016 16:06:38 +0100 Message-ID: <69285276.9idFayf1Xb@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: steeven lee Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 1E928214A for ; Mon, 8 Feb 2016 16:08:05 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id p63so119754831wmp.1 for ; Mon, 08 Feb 2016 07:08:05 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2015-12-24 20:38, steeven lee: > --- a/mk/internal/rte.extvars.mk > +++ b/mk/internal/rte.extvars.mk > # RTE_SDK_BIN must point to .config, include/ and lib/. > -RTE_SDK_BIN := $(RTE_SDK)/$(RTE_TARGET) > +RTE_SDK_BIN := $(RTE_SDK)/build RTE_TARGET is the right value here. To make it work with "build/" please use RTE_TARGET=build when building your example. > ifeq ($(wildcard $(RTE_SDK_BIN)/.config),) > -$(error Cannot find .config in $(RTE_SDK)) > +$(error Cannot find .config in $(RTE_SDK_BIN)) > endif Yes you're right, the error message looks wrong. Please, could you send a v2 patch for this fix? > --- a/mk/rte.extsubdir.mk > +++ b/mk/rte.extsubdir.mk > @@ -46,7 +46,7 @@ $(DIRS-y): > @echo "== $@" > $(Q)$(MAKE) -C $(@) \ > M=$(CURDIR)/$(@)/Makefile \ > - O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/$(@)/$(RTE_TARGET) \ > + O=$(BASE_OUTPUT)/$(CUR_SUBDIR)/build \ > BASE_OUTPUT=$(BASE_OUTPUT) \ > CUR_SUBDIR=$(CUR_SUBDIR)/$(@) \ > S=$(CURDIR)/$(@) \ I think this change is not needed. Probably your command is incorrect. Please paste them here. If the doc is incomplete, a patch would also be welcome. Thanks