From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: remove make target for examples
Date: Fri, 11 Jan 2019 23:13:13 +0100
Message-ID: <6939248.sCPUF7vAYb@xps>
References: <1479772058-7112-1-git-send-email-thomas.monjalon@6wind.com>
 <5759d5d2-9ece-abbe-587f-b19443046b87@intel.com>
 <9264cbd7-e96b-af26-b5d6-2217fdf6f351@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dpdk-dev <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id D95AD1BBDC
 for <dev@dpdk.org>; Fri, 11 Jan 2019 23:13:16 +0100 (CET)
In-Reply-To: <9264cbd7-e96b-af26-b5d6-2217fdf6f351@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/01/2019 23:01, Ferruh Yigit:
> On 11/22/2016 11:49 AM, ferruh.yigit at intel.com (Ferruh Yigit) wrote:
> > On 11/22/2016 9:38 AM, Thomas Monjalon wrote:
> >> 2016-11-22 00:34, Ferruh Yigit:
> >>> On 11/21/2016 11:47 PM, Thomas Monjalon wrote:
> >>>> The command
> >>>>   make examples
> >>>> works only if target directories have the exact name of configs.
> >>>>
> >>>> It is more flexible to use
> >>>>   make -C examples RTE_SDK=$(pwd) RTE_TARGET=build
> >>>>
> >>>> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> >>>
> >>> Instead of removing examples & examples_clean targets, what do you think
> >>> keeping them as wrapper to suggested usage, for backward compatibility.
> >>>
> >>> Something like:
> >>> "
> >>> BUILDING_RTE_SDK :=
> >>> export BUILDING_RTE_SDK
> >>>
> >>> # Build directory is given with O=
> >>> O ?= $(RTE_SDK)/examples
> >>>
> >>> # Target for which examples should be built.
> >>> T ?= build
> >>>
> >>> .PHONY: examples
> >>> examples:
> >>>         @echo ================== Build examples for $(T)
> >>>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T);
> >>>
> >>> .PHONY: examples_clean
> >>> examples_clean:
> >>>         @echo ================== Clean examples for $(T)
> >>>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean;
> >>> "
> >>
> >> What is the benefit of this makefile? Just remove -C ?
> > 
> > To keep existing targets, in case somebody use them.
> > 
> >> It is not compatible with the old behaviour, so I'm afraid it would be
> >> confusing for no real benefit.
> > 
> > Right, not fully compatible, but still can do:
> > make examples / make examples_clean
> > make examples T=x86_64-native-linuxapp-gcc
> > 
> > Overall, if you believe keeping them is confusing, I am OK with it, just
> > may need to update doc/build-sdk-quick.txt to fix "make help" output.
> 
> Hi Thomas,
> 
> There is no update on the patch for a long time, updating it as rejected, please
> send an updated version if it is still relevant.
> 
> For record, patch: https://patches.dpdk.org/patch/17174/

The goal was a clean-up.
It won't be relevant anymore when the make-based build will be removed.
So it's not relevant anymore. Let's focus on meson build.