From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mem: fix resource leak Date: Mon, 22 Oct 2018 22:34:12 +0200 Message-ID: <6977287.CUEHYN7lHI@xps> References: <9183826f1b6f3bb3d80cdde12fbd59f07f4df348.1540212745.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stable@dpdk.org To: Anatoly Burakov Return-path: In-Reply-To: <9183826f1b6f3bb3d80cdde12fbd59f07f4df348.1540212745.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/10/2018 14:57, Anatoly Burakov: > Segment preallocation code allocates an array of structures on the > heap but does not free the memory afterwards. Fix it by freeing it > at the end of the function, and changing control flow to always go > through that code path. > > Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") > > Coverity ID: 323524 > > Cc: stable@dpdk.org The right order for these tags is: Coverity issue: 323524 Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") Cc: stable@dpdk.org > Signed-off-by: Anatoly Burakov > --- > > Notes: > Not sure if stable release script picks up fixes for commits intended > for stable releases? What do you mean? Is this patch for master? The process is to Cc: stable, then it is backported. The script check-git-log.sh helps you to correctly set Cc: stable tag.