From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] test/virtual_pmd: Add
 DEV_RX_OFFLOAD_CRC_STRIP to virtual driver
Date: Wed, 4 Jul 2018 10:34:37 +0100
Message-ID: <6a272915-d628-e984-408c-2c89b3c0fdeb@intel.com>
References: <1530667905-1315-1-git-send-email-phil.yang@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: nd@arm.com
To: dev-bounces@dpdk.org, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1530667905-1315-1-git-send-email-phil.yang@arm.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/4/2018 2:31 AM, dev-bounces@dpdk.org wrote:
> Add DEV_RX_OFFLOAD_CRC_STRIP to virtual drivers since they don't
> use CRC at all, when an application requires this offload virtual
> PMDs should not return error.

Agreed.

Can you please check following patch [1] that has been applied to next-net which
adds DEV_RX_OFFLOAD_CRC_STRIP to virtual devices. Is this solves your issue?

[1]
https://patches.dpdk.org/patch/41957/

> 
> Fixes: b219c8c("test: enable HW CRC strip by default")
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> ---
>  test/test/virtual_pmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
> index f8ddc2d..591b309 100644
> --- a/test/test/virtual_pmd.c
> +++ b/test/test/virtual_pmd.c
> @@ -91,6 +91,7 @@ virtual_ethdev_info_get(struct rte_eth_dev *dev __rte_unused,
>  	dev_info->max_tx_queues = (uint16_t)512;
>  
>  	dev_info->min_rx_bufsize = 0;
> +	dev_info->rx_offload_capa = DEV_RX_OFFLOAD_CRC_STRIP;
>  }
>  
>  static int
>