From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/tap: add Rx/Tx checksum offload support
Date: Mon, 22 May 2017 13:24:41 +0100
Message-ID: <6acb1c97-0c27-da98-5c4f-292b0f87e29a@intel.com>
References: <172025985dc6ca989008cc2d93008e38ac3fff39.1495452020.git.pascal.mazon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Pascal Mazon <pascal.mazon@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4BBAE20F
 for <dev@dpdk.org>; Mon, 22 May 2017 14:24:43 +0200 (CEST)
In-Reply-To: <172025985dc6ca989008cc2d93008e38ac3fff39.1495452020.git.pascal.mazon@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Pascal,

On 5/22/2017 12:20 PM, Pascal Mazon wrote:
> This patch adds basic offloading support, widely expected in a PMD.
> 
> Verify IPv4 and UDP/TCP checksums upon packet reception, and set
> ol_flags accordingly.
> 
> On Tx, set IPv4 and UDP/TCP checksums when required, considering
> ol_flags.

These are not specific to tap and can be used by any virtual PMD, right?

What do you think moving implementation into more generic location (I
don't know where right now) and use from there, and other PMDs also can
benefit from these?

Thanks,
ferruh

> 
> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>

<...>