From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4] ethdev: replace bus specific struct with generic dev Date: Thu, 5 Apr 2018 10:19:24 +0100 Message-ID: <6ae513e1-3460-d41b-eb01-e4b493fa70a1@intel.com> References: <20180329175206.127943-1-ferruh.yigit@intel.com> <20180330151704.183495-1-ferruh.yigit@intel.com> <08358c50-1076-21c0-cf79-25d7a25d6255@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Shreyansh Jain , "Legacy, Allain (Wind River)" , Tomasz Duszynski , Thomas Monjalon To: "De Lara Guarch, Pablo" , David Marchand , santosh Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2803E1CA0A for ; Thu, 5 Apr 2018 11:19:28 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/4/2018 6:57 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, April 3, 2018 10:50 AM >> To: David Marchand ; santosh >> >> Cc: dev@dpdk.org; Shreyansh Jain ; Legacy, Allain >> (Wind River) ; Tomasz Duszynski >> ; Thomas Monjalon >> Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with >> generic dev >> >> On 4/3/2018 10:06 AM, David Marchand wrote: >>> On Mon, Apr 2, 2018 at 6:13 PM, santosh >>> wrote: >>>> On Friday 30 March 2018 08:59 PM, David Marchand wrote: >>>>> I can see we enforce the driver name by putting it after the call to >>>>> .dev_infos_get. >>>>> http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.c#n2399 >>>>> >>>>> octeontx pmd seems to try to do something about it: >>>>> http://dpdk.org/browse/dpdk/tree/drivers/net/octeontx/octeontx_ethde >>>>> v.c#n622 >>>>> >>>>> Not sure it does something, might be a thing to cleanup. >>>>> >>>>> >>>> In case, if your referring to driver_name update then indeed its a >>>> cleanup [1]. >>>> >>>> Otherwise, I don't see any issue with v4 Or may be /I /misunderstood >>>> your comment. >>> >>> I agree there is no fundamental issue. >>> >>> dev_info->device = dev->device; >>> >>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>> dev_info->driver_name = dev->device->driver->name; >>> >>> If somebody (I mean some pmd out there) has a usecase with >>> dev_info->device != dev->device, why not. >> >> Intentional let drivers update this variable although I don't also see any use case >> of it. >> >> This variable was set by PMDs before this patch, so I don't see any reason to be >> so strict here. >> >> If driver does anything ethdev will set dev_info->device for it, if it want to >> overwrite, for any reason, it will have the capability. > > Looks good to me. Will do the same for cryptodev and bbdev. > The only thing that I am missing here is an update in documentation, > adding the ABI Change in release notes. Right, I forget about it, will send a new version. Thanks, ferruh > > Apart from it: > > Acked-by: Pablo de Lara > >> >>> >>> Thomas ? >>> >>> >