From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] net/virtio: avoid double accounting of bytes Date: Thu, 20 Dec 2018 19:01:29 +0100 Message-ID: <6b65a101-3293-004b-5220-972e394f81d2@redhat.com> References: <20181220105624.31046-1-jfreimann@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: tiwei.bie@intel.com To: Jens Freimann , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9EB011BD2A for ; Thu, 20 Dec 2018 19:01:36 +0100 (CET) In-Reply-To: <20181220105624.31046-1-jfreimann@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/20/18 11:56 AM, Jens Freimann wrote: > Accounting of bytes was moved to a common function, so at the moment we do > it twice. This patches fixes it for sending packets with packed virtqueues. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 8564f18a7..8a08606fb 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1931,7 +1931,6 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts, > /* Enqueue Packet buffers */ > virtqueue_enqueue_xmit_packed(txvq, txm, slots, can_push); > > - txvq->stats.bytes += txm->pkt_len; > virtio_update_packet_stats(&txvq->stats, txm); > } > > Thanks Jens for the quick fix: Reviewed-by: Maxime Coquelin Maxime