From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4] kni: fix possible rx_q mbuf leaks and
 speed up alloc_q release
Date: Fri, 4 May 2018 13:46:05 +0100
Message-ID: <6be3fba4-46d8-45f6-caa0-7b301433a964@intel.com>
References: <9a57896f-a2db-7f4b-f5c4-cf04970f1636@intel.com>
 <1524107540-11544-1-git-send-email-zhouyates@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org, thomas@monjalon.net
To: Yangchao Zhou <zhouyates@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1524107540-11544-1-git-send-email-zhouyates@gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/19/2018 4:12 AM, Yangchao Zhou wrote:
> rx_q fifo can only be released by kernel thread. There may be
> mbuf leaks in rx_q because kernel threads are randomly stopped.
> 
> When the kni is released and netdev is unregisterd, convert the
> physical address mbufs in rx_q to the virtual address in free_q.
> By the way, alloc_q can be processed together to speed up the
> release rate in userspace.
> 
> In my test, it is improved from 300-500ms with a mempool that has
>  131072 mbufs to 10ms(regardless of the specifications).
> 
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v4:
> * Add improve performance description.

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>