From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] eal: remove exec-env directory
Date: Tue, 2 Apr 2019 20:57:54 +0100
Message-ID: <6c52aa71-5dcb-1dfe-27f3-57d11dcb5a2f@intel.com>
References: <20190401230712.31864-1-thomas@monjalon.net>
 <20190402193048.27410-1-thomas@monjalon.net>
 <CAJFAV8yj5KFqLZS7666hrCy_33qGjpAQC7BOUma=88S2BTWyew@mail.gmail.com>
 <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com>
 <CAJFAV8ywXsQv=m_1Kh9Z+6itZt86HaQ-EWC8JupVbhqq87wLZw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
 Anand Rawat <anand.rawat@intel.com>
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 345806C9B
 for <dev@dpdk.org>; Tue,  2 Apr 2019 21:57:58 +0200 (CEST)
In-Reply-To: <CAJFAV8ywXsQv=m_1Kh9Z+6itZt86HaQ-EWC8JupVbhqq87wLZw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/2/2019 8:55 PM, David Marchand wrote:
> On Tue, Apr 2, 2019 at 9:52 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> On 4/2/2019 8:46 PM, David Marchand wrote:
>>> On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon <thomas@monjalon.net>
>> wrote:
>>>
>>>> Only one header file (rte_kni_common.h) was in the sub-directory
>>>>         include/exec-env/
>>>> This file was installed in a sub-directory of the same name
>>>> in the makefile-based build.
>>>> Source and install directories are moved as below:
>>>>
>>>>    lib/librte_eal/linux/eal/include/exec-env/
>>>> -> lib/librte_eal/linux/eal/include/
>>>>
>>>>    build/include/exec-env/
>>>> -> build/include/
>>>>
>>>> The consequence is to have a file hierarchy a bit more flat.
>>>>
>>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>>>
>>>
>>> Looks good to me.
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>> Tested-by: David Marchand <david.marchand@redhat.com>
>>>
>>>
>>> Bruce, while testing with meson, I noticed this:
>>> kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument
>>> "console".
>>> WARNING: This will become a hard error in the future.
>>> WARNING: Unknown keyword arguments in target rte_kni: console
>>
>> I am not seeing this...
>>
> 
> Ok, might be my setup:
> [dmarchan@dmarchan dpdk]$ meson --version
> 0.47.2
> 
> What should I check ?

I have '0.50.0', but no idea what to check, wait Bruce :) ?