From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] net/ring: remove unnecessary NULL check
Date: Wed, 2 Nov 2016 11:38:47 +0000
Message-ID: <6c7a2a77-7370-3550-7aad-d98327f033ba@intel.com>
References: <1477972113-2600-1-git-send-email-mauricio.vasquez@polito.it>
 <1478030140-7127-1-git-send-email-mauricio.vasquez@polito.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Mauricio Vasquez B <mauricio.vasquez@polito.it>, bruce.richardson@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D2181FE5
 for <dev@dpdk.org>; Wed,  2 Nov 2016 12:38:49 +0100 (CET)
In-Reply-To: <1478030140-7127-1-git-send-email-mauricio.vasquez@polito.it>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Mauricio,

On 11/1/2016 7:55 PM, Mauricio Vasquez B wrote:
> Coverity detected this as an issue because internals->data will never be NULL,
> then the check is not necessary.
> 
> Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
> Coverity issue: 137873
> 
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
> ---
>  drivers/net/ring/rte_eth_ring.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
> index 6d2a8c1..5ca00ed 100644
> --- a/drivers/net/ring/rte_eth_ring.c
> +++ b/drivers/net/ring/rte_eth_ring.c
> @@ -599,17 +599,15 @@ rte_pmd_ring_remove(const char *name)
>  
>  	eth_dev_stop(eth_dev);
>  
> -	if (eth_dev->data) {
> -		internals = eth_dev->data->dev_private;
> -		if (internals->action == DEV_CREATE) {
> -			/*
> -			 * it is only necessary to delete the rings in rx_queues because
> -			 * they are the same used in tx_queues
> -			 */
> -			for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
> -				r = eth_dev->data->rx_queues[i];
> -				rte_ring_free(r->rng);
> -			}
> +	internals = eth_dev->data->dev_private;
> +	if (internals->action == DEV_CREATE) {
> +		/*
> +		 * it is only necessary to delete the rings in rx_queues because
> +		 * they are the same used in tx_queues
> +		 */
> +		for (i = 0; i < eth_dev->data->nb_rx_queues; i++) {
> +			r = eth_dev->data->rx_queues[i];
> +			rte_ring_free(r->rng);
>  		}
>  
>  		rte_free(eth_dev->data->rx_queues);

This patch not only removes the NULL check but also changes the logic.
after patch rx_queues, tx_queues and dev_private only freed if action is
DEV_CREATE which is wrong.

>