From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 01/10] event/dsw: add DSW device
 registration and build system
Date: Tue, 2 Oct 2018 14:43:18 +0100
Message-ID: <6ce09f6f-df2e-25f9-70ac-168484b1080e@intel.com>
References: <20180918124514.10615-1-mattias.ronnblom@ericsson.com>
 <20180918124514.10615-2-mattias.ronnblom@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 89A255B2C
 for <dev@dpdk.org>; Tue,  2 Oct 2018 15:43:21 +0200 (CEST)
In-Reply-To: <20180918124514.10615-2-mattias.ronnblom@ericsson.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/18/2018 1:45 PM, Mattias Rönnblom wrote:
> This patch contains the Meson and GNU Make build system extensions
> required for the Distributed Event Device, and also the initialization
> code for the driver itself.
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

<...>

> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Ericsson AB
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +LIB = librte_pmd_dsw_event.a
> +
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -Wno-format-nonliteral

This is causing build warning with icc [1], can you please add the flag
conditionally as done in other samples of this flag [2].

Since this patch has already merged, can you please send an incremental fix patch?


[1]
icc: command line warning #10148: option '-Wno-format-nonliteral' not supported

[2]
https://git.dpdk.org/dpdk/tree/drivers/net/qede/Makefile?h=v18.08#n40
https://git.dpdk.org/dpdk/tree/drivers/net/i40e/Makefile?h=v18.08#n38