From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Maximets <i.maximets@samsung.com>
Subject: Re: [PATCH v2] build: add meson.build for kni kernel
 module
Date: Mon, 29 Oct 2018 17:09:00 +0300
Message-ID: <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com>
References: <1539364001.8721.45.camel@debian.org>
 <CGME20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114@eucas1p1.samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
To: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Luca
 Boccassi <bluca@debian.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com
 [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CDA72FEB
 for <dev@dpdk.org>; Mon, 29 Oct 2018 15:09:05 +0100 (CET)
Received: from eucas1p1.samsung.com (unknown [182.198.249.206])
 by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id
 20181029140904euoutp016a744ce2a5662ebd30cd14446a101dfd~iGZOok9B61158611586euoutp01a
 for <dev@dpdk.org>; Mon, 29 Oct 2018 14:09:04 +0000 (GMT)
In-Reply-To: <1539364001.8721.45.camel@debian.org>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote:
>> On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote:
>> > A Kbuild is also included to allow users to use DKMS natively
>> > without
>> > additional code.
>> > 
>> > Signed-off-by: Luca Boccassi <bluca at debian.org>
>> > ---
>> > v2: add local directory to -I and build sources list recursively to
>> >     fix build on Fedora
>> > 
>> 
>> Yep, now seems to build for me on Fedora. One minor suggestion is to
>> look
>> to use the "console" keyword on the custom_target if possible. It
>> should
>> help prevent noticable stalls as make runs in the background.
>> [Unfortunately, it's meson 0.48 onward only, so if conditionals are
>> needed,
>> just ignore this suggestion]
> 
> Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there are
> no complaints or errors, it's simply ignored in the older versions.

Hmm.
I have following on my Ubuntu 18.04 with dpdk v18.11-rc1:

$ meson --version
0.45.1

$ meson build
<...>
kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument "console".
WARNING: This will become a hard error in the future.
WARNING: Unknown keyword arguments in target rte_kni: console
<...>

It builds, but prints above warning.

Best regards, Ilya Maximets.

> 
>> Also, do we want to use "make -j" for this, given the number of
>> files?
>> [Maybe -j4 just?]
> 
> Yeah makes sense, added j4.
> 
> Sent v3 with both changes and the ack, thanks.
> 
> -- 
> Kind regards,
> Luca Boccassi