From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 1/6] eal: register log type and pick level from EAL args Date: Thu, 22 Mar 2018 10:21:06 +0000 Message-ID: <6d1ac2ef-1bc4-a2ff-fc6f-d17530671bda@intel.com> References: <1516899647-8541-1-git-send-email-arybchenko@solarflare.com> <1521631701-11282-1-git-send-email-arybchenko@solarflare.com> <1521631701-11282-2-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ivan Malov To: Andrew Rybchenko , dev@dpdk.org Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BD1F02BD3 for ; Thu, 22 Mar 2018 11:21:09 +0100 (CET) In-Reply-To: <1521631701-11282-2-git-send-email-arybchenko@solarflare.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/21/2018 11:28 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Dynamic log types are registered on RTE_INIT() step. > This allows one to set log levels by EAL options on > application launch. However, this does not allow to > manage log types if they are created during runtime. > > EAL does not store log levels and types passed from > the command line. Thus, they cannot be picked later. > This is an obvious flaw since it would be better to > be able to pick levels for dynamic types registered > for runtime-determined facilities such as NIC ports. > > This patch provides a mechanism to store log levels > passed from EAL options and adds an API to register > log types and pick levels from the internal storage. > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Acked-by: Ferruh Yigit