From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v3 16/16] net/dpaa: implement scatter offload
 support
Date: Fri, 13 Jul 2018 12:02:14 +0530
Message-ID: <6d77cb11-a208-9075-592e-71f6396568ea@nxp.com>
References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com>
 <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com>
 <1530864613-11754-16-git-send-email-hemant.agrawal@nxp.com>
 <2191617.RJdI2X8ch5@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03hn0238.outbound.protection.outlook.com [104.47.10.238])
 by dpdk.org (Postfix) with ESMTP id E15591B4BA
 for <dev@dpdk.org>; Fri, 13 Jul 2018 08:32:40 +0200 (CEST)
In-Reply-To: <2191617.RJdI2X8ch5@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thursday 12 July 2018 05:53 PM, Thomas Monjalon wrote:
> Title can be "net/dpaa: support scatter offload"
> 
> 06/07/2018 10:10, Hemant Agrawal:
>> +	/* Max packet can fit in single buffer */
>> +	if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) {
>> +		;
> 
> Why an empty statement?

Its just a way of collating the cases without deep cascade. If we don't 
do this, it would just mean having multiple if cases - either cascading 
or segregated (non if-else). Either way achieves same result.

> 
>> +	} else if (dev->data->dev_conf.rxmode.enable_scatter) {
> 
> error: ‘struct rte_eth_rxmode’ has no member named ‘enable_scatter’
> 

As for this, it would be because of another patch on master: ab3ce1e0c19 
which was not factored when the tree was reviewed. So, this is a merge 
conflict. Or, maybe a rebase on an old tree before posting patches.

Also, for your comment in [1] - this patch doesn't really need a context 
- it is a feature and the headline is self-explanatory for that.

[1] https://mails.dpdk.org/archives/dev/2018-July/107793.html