From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] service: fix parameter type Date: Fri, 8 Feb 2019 15:01:09 +0000 Message-ID: <6d800c5e-39c7-66f1-c718-ae13d2db3ebc@intel.com> References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Van Haaren, Harry" , "Rao, Nikhil" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EAB6A1B5D7 for ; Fri, 8 Feb 2019 16:01:19 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/21/2019 11:43 AM, Van Haaren, Harry wrote: >> -----Original Message----- >> From: Rao, Nikhil >> Sent: Saturday, January 19, 2019 2:01 PM >> To: Van Haaren, Harry >> Cc: dev@dpdk.org; Rao, Nikhil >> Subject: [PATCH] service: fix parameter type >> >> The type of value parameter to rte_service_attr_get >> should be uint64_t *, since the attributes >> are of type uint64_t. >> >> Fixes: 4d55194d76a4 ("service: add attribute get function") >> >> Reviewed-by: Gage Eads >> Signed-off-by: Nikhil Rao > > Acked-by: Harry van Haaren > >> --- >> lib/librte_eal/common/include/rte_service.h | 2 +- >> lib/librte_eal/common/rte_service.c | 2 +- >> test/test/test_service_cores.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> For 19.02, I assume this will require the ABI change announcement. I will >> post it once this patch is acked. > > Correct - this breaks API and ABI, so certainly will need an announce. Hi Nikhil P, Can you please send a new version of this patch, that includes removing the deprecation notice too? (Keeping the ack) Thanks, ferruh > > Thanks for the fixup, -Harry >