From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] doc: announce PMD API change for set default
 MAC
Date: Wed, 31 Jan 2018 19:11:33 +0000
Message-ID: <6db58723-233e-91d1-dcf9-d1a40712f2b9@intel.com>
References: <20180129171339.20896-1-olivier.matz@6wind.com>
 <e1d01d38-eaf1-448e-bac2-1d9dec01bcb9@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 Neil Horman <nhorman@tuxdriver.com>, John McNamara
 <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id A772F1B809
 for <dev@dpdk.org>; Wed, 31 Jan 2018 20:11:36 +0100 (CET)
In-Reply-To: <e1d01d38-eaf1-448e-bac2-1d9dec01bcb9@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/30/2018 6:06 AM, Andrew Rybchenko wrote:
> On 01/29/2018 08:13 PM, Olivier Matz wrote:
>> Announce internal PMD API change in the function to set the default MAC
>> address. The objective is to be able to notify errors occurring in the
>> PMD.
>>
>> Link: https://dpdk.org/dev/patchwork/patch/32284/
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>>   doc/guides/rel_notes/deprecation.rst | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 43a39d827..8ad4407c2 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -76,3 +76,11 @@ Deprecation Notices
>>   * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
>>     respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
>>     names will be removed in v18.08.
>> +
>> +* ethdev: The prototype and the behavior of
>> +  ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
>> +  will be added to notify the caller if an error occurred in the PMD. In
>> +  ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
>> +  will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
>> +  succesfull. This modification will only impact the PMDs, not the
>> +  applications.
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>