From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37816C433F5 for ; Fri, 17 Sep 2021 11:49:41 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 4DEA3611C8 for ; Fri, 17 Sep 2021 11:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4DEA3611C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A656406B4; Fri, 17 Sep 2021 13:49:39 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0FFDC40689 for ; Fri, 17 Sep 2021 13:49:38 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 817217F51B; Fri, 17 Sep 2021 14:49:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 817217F51B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631879377; bh=juEB0NEdwGW1SdXlQnKKJTaoHOtzWmAQOnG0//13gkA=; h=Subject:To:References:From:Date:In-Reply-To; b=J4HUB4egNmODCfU0azNkQNTp72KQttHjgYpvKJraMyliZVPj8f0fODR/HbXRFm2BT fAiCdKsAMsRyLyfpqucm1OtUJXe2v7gWNmOdgDL/lAM+DMoGO7+lHyZT9rlkUzP0hv nRoxEITapll/IE9vb6Oa3R2BNYln3eQ+WRaorkRc= To: Xueming Li , dev@dpdk.org References: <20210727034134.20556-1-xuemingl@nvidia.com> <20210917093915.350863-1-xuemingl@nvidia.com> <20210917093915.350863-3-xuemingl@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <6df5ba8f-745f-feac-bc3d-c85a1950c80c@oktetlabs.ru> Date: Fri, 17 Sep 2021 14:49:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210917093915.350863-3-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/21 12:39 PM, Xueming Li wrote: > Currently, most ethdev callback api use queue ID as parameter, but Rx api -> API > and Tx queue release callback use queue object which is used in Rx and > Tx burst data plane callback. > > To align with other eth device queue configuration callbacks: > - queue release callbacks are changed to used queue ID > - all drivers are adapted > - empty drivers are removed in some drivers Empty drivers? If you mean empty callbacks, I think it should belong to the first changeset in the series. > > Signed-off-by: Xueming Li