From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [RFC] cmdline: rework as a wrapper to libedit Date: Thu, 16 Nov 2017 09:06:39 -0800 Message-ID: <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com> References: <1510234868-31053-1-git-send-email-adrien.mazarguil@6wind.com> <48C2CD08-29E1-444C-BF60-B96BE58865A5@intel.com> <20171116092356.GM24849@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Olivier Matz , "Wu, Jingjing" , "dev@dpdk.org" , Thomas Monjalon To: Adrien Mazarguil , "Wiles, Keith" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5EE561B2A9 for ; Thu, 16 Nov 2017 18:06:41 +0100 (CET) In-Reply-To: <20171116092356.GM24849@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: <...> >> I do not agree it has severed DPDK well, just look at test-pmd and the hoops people have to jump thru to get a new command or variation of an existing command integrated into test-pmd it is very difficult. Also if you look at the command sets in test-pmd they are very odd in that similar commands can some times be set up completely different as cmdline is too rigid and difficult to use. > > Testpmd is indeed messy, but this is not librte_cmdline's fundamental fault > in my opinion, more likely the result of using a copy/paste approach to new > commands due to lack of time or interest in making things nicer than the > bare minimum to validate features. There's no design direction for it hence > the lack of uniformity in the command hierarchy. Unrelated to cmdline discussion +1 for this paragraph.