* [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
@ 2026-02-27 20:20 Mohammad Shuab Siddique
2026-03-03 18:04 ` Kishore Padmanabha
0 siblings, 1 reply; 3+ messages in thread
From: Mohammad Shuab Siddique @ 2026-02-27 20:20 UTC (permalink / raw)
To: dev; +Cc: kishore.padmanabha, Keegan Freyhof, stable,
Mohammad Shuab Siddique
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Modified the way that the scalar path reports VLAN TCI
and the RTE_MBUF_F_RX_VLAN_STRIPPED flag.
Bugzilla ID: 1868
Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 3 ++-
drivers/net/bnxt/bnxt_rxr.h | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index c94abefa01..eb01132f48 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -1115,6 +1115,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
uint16_t cmp_type;
uint32_t vfr_flag = 0, mark_id = 0;
struct bnxt *bp = rxq->bp;
+ struct bnxt_vnic_info *vnic = rxq->vnic;
rxcmp = (struct rx_pkt_cmpl *)
&cpr->cp_desc_ring[cp_cons];
@@ -1198,7 +1199,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
if (cmp_type == CMPL_BASE_TYPE_RX_L2_V3) {
bnxt_parse_csum_v3(mbuf, rxcmp1);
bnxt_parse_pkt_type_v3(mbuf, rxcmp, rxcmp1);
- bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1);
+ bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1, vnic->vlan_strip);
if (BNXT_TRUFLOW_EN(bp))
mark_id = bnxt_ulp_set_mark_in_mbuf_v3(rxq->bp, rxcmp1,
mbuf, &vfr_flag);
diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
index 7357ca4427..f6d1e3ddfb 100644
--- a/drivers/net/bnxt/bnxt_rxr.h
+++ b/drivers/net/bnxt/bnxt_rxr.h
@@ -474,11 +474,14 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,
static inline void bnxt_rx_vlan_v3(struct rte_mbuf *mbuf,
struct rx_pkt_cmpl *rxcmp,
- struct rx_pkt_cmpl_hi *rxcmp1)
+ struct rx_pkt_cmpl_hi *rxcmp1,
+ bool stripped)
{
if (RX_CMP_V3_VLAN_VALID(rxcmp)) {
mbuf->vlan_tci = RX_CMP_V3_METADATA0_VID(rxcmp1);
- mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;
+ if (stripped)
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;
}
}
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
2026-02-27 20:20 [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2 Mohammad Shuab Siddique
@ 2026-03-03 18:04 ` Kishore Padmanabha
2026-03-11 17:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Kishore Padmanabha @ 2026-03-03 18:04 UTC (permalink / raw)
To: Mohammad Shuab Siddique, dev; +Cc: Keegan Freyhof, stable
[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]
Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
-----Original Message-----
From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Sent: Friday, February 27, 2026 3:20 PM
To: dev@dpdk.org
Cc: kishore.padmanabha@broadcom.com; Keegan Freyhof
<keegan.freyhof@broadcom.com>; stable@dpdk.org; Mohammad Shuab Siddique
<mohammad-shuab.siddique@broadcom.com>
Subject: [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Modified the way that the scalar path reports VLAN TCI and the
RTE_MBUF_F_RX_VLAN_STRIPPED flag.
Bugzilla ID: 1868
Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique
<mohammad-shuab.siddique@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 3 ++-
drivers/net/bnxt/bnxt_rxr.h | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index c94abefa01..eb01132f48 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -1115,6 +1115,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
uint16_t cmp_type;
uint32_t vfr_flag = 0, mark_id = 0;
struct bnxt *bp = rxq->bp;
+ struct bnxt_vnic_info *vnic = rxq->vnic;
rxcmp = (struct rx_pkt_cmpl *)
&cpr->cp_desc_ring[cp_cons];
@@ -1198,7 +1199,7 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
if (cmp_type == CMPL_BASE_TYPE_RX_L2_V3) {
bnxt_parse_csum_v3(mbuf, rxcmp1);
bnxt_parse_pkt_type_v3(mbuf, rxcmp, rxcmp1);
- bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1);
+ bnxt_rx_vlan_v3(mbuf, rxcmp, rxcmp1, vnic->vlan_strip);
if (BNXT_TRUFLOW_EN(bp))
mark_id = bnxt_ulp_set_mark_in_mbuf_v3(rxq->bp,
rxcmp1,
mbuf,
&vfr_flag);
diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
index 7357ca4427..f6d1e3ddfb 100644
--- a/drivers/net/bnxt/bnxt_rxr.h
+++ b/drivers/net/bnxt/bnxt_rxr.h
@@ -474,11 +474,14 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,
static inline void bnxt_rx_vlan_v3(struct rte_mbuf *mbuf,
struct rx_pkt_cmpl *rxcmp,
- struct rx_pkt_cmpl_hi *rxcmp1)
+ struct rx_pkt_cmpl_hi *rxcmp1,
+ bool stripped)
{
if (RX_CMP_V3_VLAN_VALID(rxcmp)) {
mbuf->vlan_tci = RX_CMP_V3_METADATA0_VID(rxcmp1);
- mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN |
RTE_MBUF_F_RX_VLAN_STRIPPED;
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;
+ if (stripped)
+ mbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;
}
}
--
2.47.3
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5493 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2
2026-03-03 18:04 ` Kishore Padmanabha
@ 2026-03-11 17:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2026-03-11 17:08 UTC (permalink / raw)
To: Keegan Freyhof; +Cc: Mohammad Shuab Siddique, dev, stable, Kishore Padmanabha
> Modified the way that the scalar path reports VLAN TCI and the
> RTE_MBUF_F_RX_VLAN_STRIPPED flag.
>
> Bugzilla ID: 1868
> Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")
> Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
> Signed-off-by: Mohammad Shuab Siddique
> <mohammad-shuab.siddique@broadcom.com>
Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-11 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 20:20 [PATCH] net/bnxt: fix reported VLAN stripped flag for Thor 2 Mohammad Shuab Siddique
2026-03-03 18:04 ` Kishore Padmanabha
2026-03-11 17:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox