From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] eal: move runtime dir creation after args parse Date: Tue, 15 May 2018 13:16:52 +0100 Message-ID: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Bruce Richardson , thomas@monjalon.net To: Andrew Rybchenko , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 396121B783 for ; Tue, 15 May 2018 14:16:59 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15-May-18 12:36 PM, Andrew Rybchenko wrote: > On 05/15/2018 01:44 PM, Anatoly Burakov wrote: >> The intention of the original code was to create runtime data >> directory as early as possible, however it was moved too early, >> before the arguments were parsed, resulting in --file-prefix >> option essentially not working. >> >> Fix this by moving eal_create_runtime_dir() to after command >> line arguments parsing. >> >> Fixes: 56236363b481 ("eal: add directory for runtime data") >> >> Reported-by: Andrew Rybchenko >> >> Signed-off-by: Anatoly Burakov > > Tested-by: Andrew Rybchenko > > I've tested it quickly and it solves the problem I observe. > I suppose it is OK that the directory remains after application exit. > Previously, all of the files that we were creating during runtime remained, so having a directory where all the files are is better than having a scattering of files :) Thanks for testing! -- Thanks, Anatoly