From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 30/31] net/ice: support advance RX/TX
Date: Mon, 17 Dec 2018 23:46:30 +0000
Message-ID: <6f9054d5-fe3a-2f07-fcf5-da78f091678b@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-31-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id DE3AE1B9F1
 for <dev@dpdk.org>; Tue, 18 Dec 2018 00:46:35 +0100 (CET)
In-Reply-To: <1545032259-77179-31-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add RX functions, scatter and bulk.
> Add TX function, simple.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

<....>

> +	rxdp = &rxq->rx_ring[alloc_idx];
> +	for (i = 0; i < rxq->rx_free_thresh; i++) {
> +		if (likely(i < (rxq->rx_free_thresh - 1)))
> +			/* Prefetch next mbuf */
> +			rte_prefetch0(rxep[i + 1].mbuf);
> +
> +		mb = rxep[i].mbuf;
> +		rte_mbuf_refcnt_set(mb, 1);
> +		mb->next = NULL;
> +		mb->data_off = RTE_PKTMBUF_HEADROOM;
> +		mb->nb_segs = 1;
> +		mb->port = rxq->port_id;
> +		dma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(mb));
> +		rxdp[i].read.hdr_addr = 0;
> +		rxdp[i].read.pkt_addr = dma_addr;
> +	}
> +
> +	/* Update rx tail regsiter */

Can you please double check checkpatch warnings, some of them can be ignored but
some are easy to fix issues:
 WARNING:TYPO_SPELLING: 'regsiter' may be misspelled - perhaps 'register'?
 #201: FILE: drivers/net/ice/ice_lan_rxtx.c:1112:
 +	/* Update rx tail regsiter */