From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] examples: fix RSS hash function configuration
Date: Wed, 20 Jun 2018 18:15:33 +0100
Message-ID: <6fcf5346-318b-d773-82ee-d28489d6b2ae@intel.com>
References: <20180620150122.45945-1-ferruh.yigit@intel.com>
 <d00e6b84-ac5a-dae0-fba6-5f40d0bf69b2@intel.com>
 <CAGyogRaDw0mLLY+3w9_7JqAF3E2cHDfKOUkiFgXbtkHMDdahBA@mail.gmail.com>
 <CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Dan Gora <dg@adax.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 9B40F1B50E
 for <dev@dpdk.org>; Wed, 20 Jun 2018 19:15:35 +0200 (CEST)
In-Reply-To: <CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/20/2018 6:07 PM, Dan Gora wrote:
> Hi Ferruh,
> 
> The documentation for rte_eth_dev_configure() should get updated as
> well to document this requirement to strip the unsupported RSS hash
> function bits.  The current documentation only refers to the tx/rx
> offload bits:
> 
>  *     -  Any offloading set in eth_conf->[rt]xmode.offloads must be within
>  *        the [rt]x_offload_capa returned from rte_eth_dev_infos_get().
>  *        Any type of device supported offloading set in the input argument
>  *        eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled
>  *        on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup().

Agreed, will update the patch according.

> 
> thanks
> dan
> 
> 
> On Wed, Jun 20, 2018 at 10:03 AM, Dan Gora <dg@adax.com> wrote:
>> Hi Ferruh,
>>
>> Thanks for this.. I had started working on a patch to do this as well
>> because I got bit by this error.
>>
>> Shouldn't all of the example applications also add the code to strip
>> the unsupported Tx and Rx offload bits as well?  It would help new
>> users (like me!) to understand that this is a requirement for all
>> callers of rte_eth_dev_configure().
>>
>>     rte_eth_dev_info_get(port_id, &dev_info);
>>
>>     /* Only set the offload bits which are actually supported */
>>     port_conf.txmode.offloads &= dev_info.tx_offload_capa;
>>     port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
>>
>> thanks
>> dan