From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call
Date: Thu, 18 Dec 2014 17:40:05 +0100 [thread overview]
Message-ID: <709461311.gdq8zXb54j@xps13> (raw)
In-Reply-To: <20141218081712.62ebca0c@urahara>
2014-12-18 08:17, Stephen Hemminger:
> On Wed, 17 Dec 2014 12:03:28 -0500
> Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> wrote:
[...]
> > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This
> > patch makes the needed correction to avoid a build break
[...]
>
> If we could fix the header incompatiablities then the driver could use
> a standard library like ether_aton() instead of dragging in the unnecessary
> cmdline library.
Right.
A first fix was done to remove conflict with netinet/in.h:
http://dpdk.org/browse/dpdk/commit/?id=d07180f211
But there still are conflicts with netinet/ether.h and maybe more.
I suggest to fix it in the release 2.0.
--
Thomas
next prev parent reply other threads:[~2014-12-18 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 17:03 [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call Neil Horman
[not found] ` <1418835808-18803-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-17 22:20 ` Thomas Monjalon
2014-12-18 11:25 ` Neil Horman
[not found] ` <20141218112523.GA18008-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-18 12:21 ` Thomas Monjalon
2014-12-18 19:57 ` Neil Horman
2014-12-18 13:51 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CA0EE5-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 19:58 ` Neil Horman
2014-12-18 3:40 ` Cao, Waterman
[not found] ` <AA3F441F262C58498CD6D0C1801DE7EB0AC3A900-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 11:26 ` Neil Horman
2014-12-18 8:40 ` Olivier MATZ
[not found] ` <54929301.2010007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-18 9:26 ` Olivier MATZ
2014-12-18 11:31 ` [PATCH v2] " Neil Horman
2014-12-18 13:45 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CA0ECB-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 20:54 ` Neil Horman
2014-12-19 5:02 ` Qiu, Michael
[not found] ` <1418902316-30266-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-18 22:13 ` Thomas Monjalon
2014-12-18 16:17 ` [PATCH] " Stephen Hemminger
2014-12-18 16:40 ` Thomas Monjalon [this message]
2014-12-18 20:57 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=709461311.gdq8zXb54j@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox