From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v3 26/68] bus/fslmc: use memseg walk instead of iteration Date: Thu, 5 Apr 2018 19:36:12 +0530 Message-ID: <70a70e1a-9bed-1efe-0778-e775f1b651f7@nxp.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Hemant Agrawal , Shreyansh Jain , Nipun Gupta , Santosh Shukla , Jerin Jacob , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, olivier.matz@6wind.com, gowrishankar.m@linux.vnet.ibm.com To: Anatoly Burakov , dev@dpdk.org Return-path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10066.outbound.protection.outlook.com [40.107.1.66]) by dpdk.org (Postfix) with ESMTP id 96B941C9ED for ; Thu, 5 Apr 2018 15:51:05 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Anatoly, On Wednesday 04 April 2018 04:51 AM, Anatoly Burakov wrote: > Signed-off-by: Anatoly Burakov > --- > drivers/bus/fslmc/fslmc_vfio.c | 78 ++++++++++++++++++++++-------------------- > drivers/event/dpaa2/Makefile | 3 ++ > drivers/mempool/dpaa2/Makefile | 3 ++ > drivers/net/dpaa2/Makefile | 3 ++ > drivers/net/dpaa2/meson.build | 3 ++ > drivers/net/octeontx/Makefile | 3 ++ > 6 files changed, 56 insertions(+), 37 deletions(-) > > diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c > index 1310190..ccdbeff 100644 > --- a/drivers/bus/fslmc/fslmc_vfio.c > +++ b/drivers/bus/fslmc/fslmc_vfio.c > @@ -193,17 +193,51 @@ static int vfio_map_irq_region(struct fslmc_vfio_group *group) > return -errno; [...] I will send an incremental patch, in reply to this, which fixes dpaa2 for va cases. Though, I think this patch can be completely replaced by that - if you prefer that, let me know and I will send it non-incremental (master based). > diff --git a/drivers/net/dpaa2/meson.build b/drivers/net/dpaa2/meson.build > index ad1724d..8e96b5a 100644 > --- a/drivers/net/dpaa2/meson.build > +++ b/drivers/net/dpaa2/meson.build > @@ -13,3 +13,6 @@ sources = files('base/dpaa2_hw_dpni.c', > 'mc/dpni.c') > > includes += include_directories('base', 'mc') > + > +# depends on fslmc bus which uses experimental API > +allow_experimental_apis = true > diff --git a/drivers/net/octeontx/Makefile b/drivers/net/octeontx/Makefile > index 3e4a106..5f488b9 100644 > --- a/drivers/net/octeontx/Makefile > +++ b/drivers/net/octeontx/Makefile > @@ -16,6 +16,9 @@ EXPORT_MAP := rte_pmd_octeontx_version.map > > LIBABIVER := 1 > > +# depends on fslmc bus which uses experimental API I think you wanted to say "octeontx" rather than fslmc here. Also, this is not part of 'bus/fslmc' patch. > +CFLAGS += -DALLOW_EXPERIMENTAL_API > + > OBJS_BASE_DRIVER=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c))) > $(foreach obj, $(OBJS_BASE_DRIVER), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))) > > If the Octeon part is removed from above, and incremental patch is merged here, please use my Ack: Acked-by: Shreyansh Jain