From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] nfp: fix mbuf releasing when segments
Date: Wed, 26 Apr 2017 21:07:49 +0100
Message-ID: <70f8576a-226f-f46c-e2db-de6794915181@intel.com>
References: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/26/2017 11:27 AM, Alejandro Lucero wrote:
> If segments are used, just mbufs previously linked to head descriptor of
> a mbuf chain are released. Other tx descriptor are used for the mbuf chain
> but they keep their linked mbufs without releasing them. It is not a fatal
> issue because sooner or later those descriptors will be head descriptors or
> just used for a single mbuf packet, then those linked mbufs will be released.
> However, this leads to apps needing bigger mbufs pools and some confusion
> about memory requeriments. Indeed, because larget pools, some performance
> impact could also be exptected due to cache misses.
> 
> With this patch all tx descriptors will release linked mbufs inside the
> xmit function, and rte_pktmbuf_seg_free is used instead of rte_pktmbuf_free.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Applied to dpdk-next-net/master, thanks.