From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v1 1/1] examples/l2fwd-crypto: improve random
	key generator
Date: Sat, 16 Jul 2016 00:09:24 +0200
Message-ID: <7101230.lS75CnBRjb@xps13>
References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 2BA79558C
 for <dev@dpdk.org>; Sat, 16 Jul 2016 00:09:26 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id f126so40836467wma.1
 for <dev@dpdk.org>; Fri, 15 Jul 2016 15:09:26 -0700 (PDT)
In-Reply-To: <592ce77e-576f-d17d-d0b6-c9caed081c3c@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-13 16:55, Declan Doherty:
> On 05/25/2016 02:34 PM, Piotr Azarewicz wrote:
> > This patch improve generate_random_key() function by replacing rand()
> > function with reading from /dev/urandom.
> >
> > CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> > dont_call: rand should not be used for security related applications, as
> > linear congruential algorithms are too easy to break
> >
> > Coverity issue: 120136
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> 
> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied, thanks