From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] ether: use a default for max Rx frame
	size in configure()
Date: Fri, 07 Apr 2017 14:15:47 +0200
Message-ID: <7103767.xpENpphzvJ@xps13>
References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com>
 <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com
 [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id AAE4B2BB0
 for <dev@dpdk.org>; Fri,  7 Apr 2017 14:15:49 +0200 (CEST)
Received: by mail-wr0-f170.google.com with SMTP id o21so76708143wrb.2
 for <dev@dpdk.org>; Fri, 07 Apr 2017 05:15:49 -0700 (PDT)
In-Reply-To: <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-04-07 13:02, Andriy Berestovskyy:
> At the moment rte_eth_dev_configure() behaves inconsistent:
>  - for normal frames: zero max_rx_pkt_len uses a default
>  - for jumbo frames: zero max_rx_pkt_len gives an error
> 
> This patch fixes this inconsistency by using a default value
> if max_rx_pkt_len is zero both for normal and jumbo frames.
> 
> Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
> ---
> 
> Notes:
>     v3 changes:
>      - use a default only if max_rx_pkt_len is zero

Looks good.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

It is a small API change but it is fixing an inconsistency,
so I think it can be integrated in 17.05-rc2 as is.
Any different opinion?