From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] sched: patches for 2.2 Date: Mon, 14 Mar 2016 00:09:27 +0100 Message-ID: <7147300.0jXl9hpqrT@xps13> References: <1448822809-8350-1-git-send-email-stephen@networkplumber.org> <4107462.qD4IMYcbAE@xps13> <3EB4FA525960D640B5BDFFD6A3D891264796D475@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Dumitrescu, Cristian" , Stephen Hemminger Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 1EF5F47CD for ; Mon, 14 Mar 2016 00:10:50 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id n186so85194370wmn.1 for ; Sun, 13 Mar 2016 16:10:50 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891264796D475@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-13 22:47, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-08 07:49, Dumitrescu, Cristian: > > > Regarding Stephen's patches, I think there is a pending issue regarding the > > legal side of the Copyright, which is attributed to Intel, although Stephen's > > code is relicensed with BSD license by permission from the original code > > author (which also submitted the code to Linux kernel under GPL). This was > > already flagged. This is a legal issue and I do not feel comfortable with ack-ing > > this patch until the legal resolution on this is crystal clear. > > > > > > I also think the new files called rte_reciprocal.[hc] implement an algorithm > > that is very generic and totally independent of the QoS code, therefore it > > should be placed into a different folder that is globally visible to other > > libraries (librte_eal/common ?) just in case other usages for this algorithm > > are identified in the future. I suggest we break the patch into two separate > > patches submitted independently: one introducing the rte_reciprocal.[hc] > > algorithm to librte_eal/common and the second containing just the > > librte_sched changes, which are small. I am thinking ahead here: once we > > have the 2x64-bit multiplication solution in place, we should not have > > rte_reciprocal.[hc] hanging in librte_sched folder without being used here, > > while it might be used by other parts of DPDK. > > > > Let's keep the improvement as-is to test it in the first release candidate. > > We can move the code and/or fix the file header later. > > > > Series applied, thanks. > > Hi Thomas, > > I am OK with this, as long as Stephen commits to fix the copyright in the > header file There is no copyright issue. Just an Intel mention in the disclaimer. > and move the rte_reciprocal.[hc] into a common area like > librte_eal/common in time for the next release candidate. If it is moved as a public API, it must be better documented. If it stay here, it must be removed from SYMLINK-y-include.