From: fengchengwen <fengchengwen@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [PATCH v3] examples/l3fwd: dynamic NUMA-aware alloc lcore_conf
Date: Wed, 4 Nov 2026 10:08:51 +0800 [thread overview]
Message-ID: <714a77be-ce37-4ebe-8cb5-96fbc6cdffe9@huawei.com> (raw)
In-Reply-To: <cf705046-36bd-4b38-bc56-6106bbba335b@huawei.com>
On 11/2/2026 12:13 PM, fengchengwen wrote:
> On 11/1/2026 10:26 PM, Thomas Monjalon wrote:
>> 31/10/2026 02:37, fengchengwen:
>>> On 10/30/2026 8:59 PM, Thomas Monjalon wrote:
>>>> 30/10/2026 11:52, Konstantin Ananyev:
>>>>>> BTW: SOCKET_ID_ANY seemed need redefined as RTE_SOCKET_ID_ANY, If there is no
>>>>>> objection, I will make the changes in the next independent patch.
>>>>>
>>>>> Yep, that's probably a good thing to do, and probably 26.11 is a good
>>>>> time to do that.
>>>>> BTW, I think it was discussed before, but I can't remember why we didn't
>>>>> fix it so far.
>>>>
>>>> 1/ We should not break this API easily as it is used a lot.
>>>> If we do the change we need to keep the compat alias for some time.
>>>>
>>>> 2/ The term SOCKET is used in many places instead of NUMA.
>>>> There is a confusion between CPU and memory which deserves to be fixed.
>>>>
>>>
>>> My plan is a 3-patch series:
>>> 1. Add RTE_SOCKET_ID_ANY and deprecation documentation.
>>> 2. Replace all in-tree SOCKET_ID_ANY with RTE_SOCKET_ID_ANY.
>>> 3. Mark SOCKET_ID_ANY with RTE_DEPRECATED after in-tree migration completes,
>>> so warnings only hit out-of-tree users while DPDK itself builds cleanly.
>>>
>>> I will avoid the bigger "socket -> NUMA node" terminology refactor in this series.
>>> That would be a massive semantic change with large churn, better handled via separate
>>> RFC later.
>>>
>>> If this plan looks acceptable, I will start the implementation.
>>
>> My doubt is that while introducing a new API,
>> it may be better to apply it in correct places with correct definition,
>> avoiding mixing CPU and memory.
>
> OK, I will try to implement it (avoiding mixing CPU and memory)
I have sent out the full patch series for the tree-wide NUMA terminology
refactor as we briefly discussed. The overall modification scope is
quite large, touching many areas across DPDK.
I understand this brings substantial code churn and API compatibility
concerns. I would appreciate hearing feedback and guidance from the
community on how we should proceed.
Regards,
Chengwen
>
>>
>>
>
next prev parent reply other threads:[~2026-11-04 2:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 3:23 [PATCH] examples/l3fwd: dynamic NUMA-aware alloc lcore_conf Chengwen Feng
2026-06-24 3:23 ` [PATCH v2] " Chengwen Feng
2026-06-24 4:26 ` Stephen Hemminger
2026-06-24 6:05 ` fengchengwen
2026-07-12 0:36 ` Thomas Monjalon
2026-07-15 9:22 ` [PATCH] " Chengwen Feng
2026-10-29 2:54 ` [PATCH v3] " Chengwen Feng
2026-10-29 9:19 ` Konstantin Ananyev
2026-10-29 12:12 ` fengchengwen
2026-10-30 10:52 ` Konstantin Ananyev
2026-10-30 12:59 ` Thomas Monjalon
2026-10-31 1:37 ` fengchengwen
2026-11-01 14:26 ` Thomas Monjalon
2026-11-02 4:13 ` fengchengwen
2026-11-04 2:08 ` fengchengwen [this message]
2026-10-29 12:09 ` [PATCH v4] " Chengwen Feng
2026-10-30 10:48 ` Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714a77be-ce37-4ebe-8cb5-96fbc6cdffe9@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox