From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC6EC433DB for ; Tue, 30 Mar 2021 13:51:06 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D0FEB6192B for ; Tue, 30 Mar 2021 13:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0FEB6192B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C640F406B4; Tue, 30 Mar 2021 15:51:04 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 6516440691 for ; Tue, 30 Mar 2021 15:51:03 +0200 (CEST) IronPort-SDR: JhNfKgF1dr7C8EJppFNPUxb/+66+KiWgiz4L0aUjvVBznjvcfqHfOqWhZ1FblpKvWIEJu77LxL wgNwrX0VO77A== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="255759729" X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="255759729" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 06:51:02 -0700 IronPort-SDR: tXIqbLyhHTzBmnwcWY02UE83KQydKohlJ3JNpX53nOS+o3784TCMoy5PwuG/KO5J5ntTsrdYHM iZcLmfagGDhA== X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="418180926" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.213.217]) ([10.213.213.217]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 06:51:01 -0700 To: Ciara Loftus , dev@dpdk.org References: <20210325082209.29550-1-ciara.loftus@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <714bf2ff-4ddb-a178-cbbe-f1541e4db1ac@intel.com> Date: Tue, 30 Mar 2021 14:50:57 +0100 MIME-Version: 1.0 In-Reply-To: <20210325082209.29550-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix unchecked return of recvfrom() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 8:22 AM, Ciara Loftus wrote: > Coverity complains that the return value of recvfrom() in the AF_XDP > datapath is not checked. We don't care about the return value because in > the case of an error we still return 0 from the receive function to > indicate no packets were received. So to make Coverity happy we cast the > return to 'void'. > > Coverity issue: 369671 > Fixes: 63e8989fe5a4 ("net/af_xdp: use recvfrom instead of poll syscall") > > Signed-off-by: Ciara Loftus Applied to dpdk-next-net/main, thanks.