From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4 1/3] ethdev: fix invalid device configuration after failure Date: Tue, 13 Nov 2018 17:49:49 +0000 Message-ID: <714cb521-bc12-b844-cac2-cc1a68d33ce1@intel.com> References: <1541642954-37497-1-git-send-email-wenzhuo.lu@intel.com> <20181113111238.80107-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Wenzhuo Lu , stable@dpdk.org To: Andrew Rybchenko , Thomas Monjalon Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/13/2018 11:19 AM, Andrew Rybchenko wrote: > On 11/13/18 2:12 PM, Ferruh Yigit wrote: >> From: Wenzhuo Lu >> >> The new configuration is stored during the rte_eth_dev_configure() API >> but the API may fail. After failure stored configuration will be >> invalid since it is not fully applied to the device. >> >> We better roll the configuration back after failure. >> >> Fixes: af75078fece3 ("first public release") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wenzhuo Lu >> Signed-off-by: Ferruh Yigit > > Reviewed-by: Andrew Rybchenko > Series applied to dpdk-next-net/master, thanks.