From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 3/4] pci: add req handler field to generic
	pci device
Date: Mon, 15 Oct 2018 12:01:10 +0200
Message-ID: <7174153.WpdsCtqFOP@xps>
References: <1534503091-31910-1-git-send-email-jia.guo@intel.com>
 <1538635483-92222-4-git-send-email-jia.guo@intel.com>
 <2017914.N0vOHbfrR3@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com,
 jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com,
 harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com,
 bernard.iremonger@intel.com, arybchenko@solarflare.com,
 anatoly.burakov@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com,
 helin.zhang@intel.com, jerin.jacob@caviumnetworks.com
To: Jeff Guo <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A6AE1160
 for <dev@dpdk.org>; Mon, 15 Oct 2018 12:01:13 +0200 (CEST)
In-Reply-To: <2017914.N0vOHbfrR3@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

15/10/2018 11:12, Thomas Monjalon:
> 04/10/2018 08:44, Jeff Guo:
> > There are some extended interrupt types in vfio pci device except from the
> > existing interrupts, such as err and req notifier, they could be useful for
> > device error monitoring. And these corresponding interrupt handler is
> > different from the other interrupt handler that register in PMDs, so a new
> > interrupt handler should be added. This patch will add specific req handler
> > in generic pci device.
> > 
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> 
> > --- a/drivers/bus/pci/rte_bus_pci.h
> > +++ b/drivers/bus/pci/rte_bus_pci.h
> > @@ -66,6 +66,7 @@ struct rte_pci_device {
> >  	uint16_t max_vfs;                   /**< sriov enable if not zero */
> >  	enum rte_kernel_driver kdrv;        /**< Kernel driver passthrough */
> >  	char name[PCI_PRI_STR_SIZE+1];      /**< PCI location (ASCII) */
> > +	struct rte_intr_handle req_notifier_handler;/**< Req notifier handle */
> 
> We had intr_handle, should we name this one req_notifier_handle?
> May we improve the comment to better explain? (and add a space before)

On IRC, we agreed on this name/comment:

struct rte_intr_handle vfio_req_intr_handle; /**< Handler of VFIO request interrupt */

> Maybe we need to update the comment of the other handle?
>     struct rte_intr_handle intr_handle; /**< Interrupt handle */

OK to keep this one as-is.