From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] kni: fix use of undefined comma variable in
	makefile
Date: Tue, 07 Jun 2016 10:32:36 +0200
Message-ID: <7183463.xOdGnD08m0@xps13>
References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com>
 <574C6E71.3090601@intel.com> <574D933C.2080507@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, helin.zhang@intel.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 0BDF995D3
 for <dev@dpdk.org>; Tue,  7 Jun 2016 10:32:38 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id n184so125645714wmn.1
 for <dev@dpdk.org>; Tue, 07 Jun 2016 01:32:38 -0700 (PDT)
In-Reply-To: <574D933C.2080507@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-31 14:35, Ferruh Yigit:
> On 5/30/2016 5:46 PM, Ferruh Yigit wrote:
> > On 5/30/2016 5:21 PM, Olivier Matz wrote:
> >> Hi Ferruh,
> >>
> >> On 05/30/2016 05:49 PM, Ferruh Yigit wrote:
> >>> On 5/30/2016 12:56 PM, Olivier Matz wrote:
> >>>> The $(comma) variable is not defined in this Makefile, nor in
> >>>> any included Makefile. Seen while doing a "make clean" on ubuntu=
:
> >>>>
> >>>>   $ make clean
> >>>>   =3D=3D Clean lib
> >>>>   =3D=3D Clean lib/librte_compat
> >>>>   =3D=3D Clean lib/librte_eal
> >>>>   =3D=3D Clean lib/librte_eal/common
> >>>>   =3D=3D Clean lib/librte_eal/linuxapp
> >>>>   =3D=3D Clean lib/librte_eal/linuxapp/eal
> >>>>   =3D=3D Clean lib/librte_eal/linuxapp/igb_uio
> >>>>   =3D=3D Clean lib/librte_eal/linuxapp/kni
> >>>>   tr: missing operand after =E2=80=98.-=E2=80=99
> >>>>   Two strings must be given when translating.
> >>>>   Try 'tr --help' for more information.
>=20
> Error is related to the kernel version, in second call "comma"
> definition comes from kernel makefiles.
>=20
> Following commit causes comma to be defined:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi=
t/?id=3D371fdc77af44f4cb32475fd499e1d912ccc30890
>=20
> So this is valid issue for old kernels, and using "," directly looks =
OK.
>=20
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Acked-by Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks