From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] app/testpmd: allow setting shaper profile
	id	to none
Date: Mon, 23 Apr 2018 21:47:21 +0200
Message-ID: <7191843.31ITM4uCTE@xps>
References: <1517297828-3111-1-git-send-email-tdu@semihalf.com>
 <20180216081339.GB25327@sh>
 <54CBAA185211B4429112C315DA58FF6D332FA7C3@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Singh, Jasvinder" <jasvinder.singh@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3DE04DED
 for <dev@dpdk.org>; Mon, 23 Apr 2018 21:47:24 +0200 (CEST)
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332FA7C3@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/02/2018 10:38, Singh, Jasvinder:
> > On Tue, Jan 30, 2018 at 08:37:08AM +0100, Tomasz Duszynski wrote:
> > > Private shaper profiles are attached to nodes defined in traffic
> > > manager hierarchy.
> > >
> > > Since not every node must have a configured shaper testpmd should
> > > allow setting shaper profile id to invalid
> > > (RTE_TM_SHAPER_PROFILE_ID_NONE) easily.
> > >
> > > This patch follows same approach as in case of setting parent id of
> > > the root node i.e passing a negative value sets node id to
> > > RTE_TM_NODE_ID_NULL.
> > >
> > > In case of private shaper profile negative value will set shaper
> > > profile id to RTE_TM_SHAPER_PROFILE_ID_NONE.
> > >
> > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> 
> Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied, thanks