From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 2/3] net/virtio: add the missing supported features Date: Thu, 27 Sep 2018 13:49:22 +0200 Message-ID: <7199aa80-d7a3-c79b-cfdf-0541a9769151@redhat.com> References: <20180921125244.27861-1-tiwei.bie@intel.com> <20180921125244.27861-3-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Return-path: In-Reply-To: <20180921125244.27861-3-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/21/2018 02:52 PM, Tiwei Bie wrote: > The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 > and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. > But they are missing in the supported feature set. And since > below commit: > > commit 4174a7b59d05 ("net/virtio: improve Tx offload features negotiation") > > Virtio PMD will announce the Tx offloading capabilities based > on the features read from the device. And virtio-user won't > report the features which are not in virtio-PMD's supported > feature set. So since that commit, virtio-user won't announce > the DEV_TX_OFFLOAD_UDP_CKSUM, DEV_TX_OFFLOAD_TCP_CKSUM and > DEV_TX_OFFLOAD_TCP_TSO offloading capabilities even if the > vhost backend supports them. > > This patch adds these missing features, and virtio-user will > report them if the backend supports them. > > Fixes: 142678d42959 ("net/virtio-user: fix wrongly get/set features") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Maxime Coquelin