From mboxrd@z Thu Jan 1 00:00:00 1970 From: gowrishankar muthukrishnan Subject: Re: [PATCH v2] eal: sPAPR IOMMU support in pci probing for vfio-pci in ppc64le Date: Fri, 3 Mar 2017 18:01:43 +0530 Message-ID: <71ab9f24-4e52-dff8-edde-9374eb8c8d81@linux.vnet.ibm.com> References: <89825b7a9e0758dea19a01eb347c0753bf2c4134.1488480000.git.gowrishankar.m@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Chao Zhu , Thomas Monjalon , Pradeep To: "Burakov, Anatoly" , "dev@dpdk.org" Return-path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 0560537B0 for ; Fri, 3 Mar 2017 13:32:47 +0100 (CET) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v23CT38M110798 for ; Fri, 3 Mar 2017 07:32:47 -0500 Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) by mx0a-001b2d01.pphosted.com with ESMTP id 28xs8env9e-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 03 Mar 2017 07:32:46 -0500 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Mar 2017 22:32:43 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 108B42BB0045 for ; Fri, 3 Mar 2017 23:32:42 +1100 (EST) Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v23CWXnF45154542 for ; Fri, 3 Mar 2017 23:32:42 +1100 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v23CW9gB005308 for ; Fri, 3 Mar 2017 23:32:09 +1100 In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, On Friday 03 March 2017 02:38 PM, Burakov, Anatoly wrote: > > Please correct me if I'm wrong here, but wouldn't all of these SPAPR-specific defines > and structures not be available for pre-4.2? So the kernel check should also > contain all the definitions and structs as well. Maybe it's better to just not compile > SPAPR support on older kernels, rather than duplicating all the VFIO code. > > Any opinions? > > Thanks for this check. As far as its trace in linux main stream, I see it was merged in 4.2. But, it depends on distro when we go back in older kernels. Some distros may have back-ported it too - eg. linux-3.10.0-514.6.2.el7 in RHEL 7.2 supports it. So, we might realise whether not supported, only in run time (atleast without autoconf sort of stuff in dpdk) IMO. any thoughts ?. Regards, Gowrishankar