From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 1/3] net/tap: add queue and port ids in
	Rx/Tx queues structures
Date: Wed, 10 Oct 2018 16:07:47 +0200
Message-ID: <7239433.uTLSZrmg9m@xps>
References: <1539154988-20652-1-git-send-email-rasland@mellanox.com>
 <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>,
 Ori Kam <orika@mellanox.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
 Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2C1861B508
 for <dev@dpdk.org>; Wed, 10 Oct 2018 16:07:51 +0200 (CEST)
In-Reply-To: <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/10/2018 14:50, Wiles, Keith:
> 
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> > 
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> 
> This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we wanted the change. It is a bit of nit picking.

I think the question "why" must be answered in the body.