From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDC6C2D0A8 for ; Mon, 28 Sep 2020 09:06:36 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 397A621D7F for ; Mon, 28 Sep 2020 09:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397A621D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5410D1D67F; Mon, 28 Sep 2020 11:06:33 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id BF5011D5D6 for ; Mon, 28 Sep 2020 11:06:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C8E22B36; Mon, 28 Sep 2020 05:06:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 28 Sep 2020 05:06:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= GFg8JWqpwr/iqaUdRSa3tdhgtrwKSOqDT1D/flPaeRk=; b=qfHczpusQmKEjimj h47iE/47UfEhPKOm89sv7l7hh/L+4EaMnqc6Q8ZDPgWpiRLCdHAqaqhnEvgAn9gT aY0b2awoCm8s3WKfaS4Rhe0ej1cqf4kjHKoViea9GRZ7Co+MpgKUJO02D8nC2s5N Eiz0F8zFNuRHo6/NPKU9rULpMe5XTx9rzQ57jpNZ3EAH0TGwrPIEgTVNzcp53BDU mCgRN3+J7qFZO+vyT8hOeTnK3I+P3T3hosDR61Osp1/MVhOgTAJQdYUFVJaA4tPT dLfG9kw8wxJZWBRUSOW3xTdUce3zG4uJjJkg8Ls5b57rrHD4LnX6ms2VZIWO0Dhr NTKwZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=GFg8JWqpwr/iqaUdRSa3tdhgtrwKSOqDT1D/flPae Rk=; b=s3S/cEf0lTaORooOurBF4bKnBuVs3gxAXk8Zdf1m80t9FLNY7AkkI5lT0 PngJHdtZIa0eUeq2Wa0+bcz5kgw4tOtMzSmOeIxBCF/FKZ1OiuMEqyRjTZZklzQN hbXQoFTnXc3/GxZAsDVcGfXXs/hmpoHwwONWsy4Uw0cGIiavaQZ87rdUxTJ62nCJ dFFS0i74/0FCq+05V2BYmcFSojSXoyMhwzoSJz8fMuTbfH+Fj/ggfZndyLp++pep i5fYT5pDableV6BP0QeLBm811iKf5bKONvyn5bkScdH1HxE7GIuJu/H12lNFWY1l pOwS0HPCxZQLL9VunGumknXNLQ0zQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8703D3280063; Mon, 28 Sep 2020 05:06:26 -0400 (EDT) From: Thomas Monjalon To: "Sachin Saxena (OSS)" Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Mon, 28 Sep 2020 11:06:24 +0200 Message-ID: <7243044.bp78lGCCmC@thomas> In-Reply-To: <20200928085713.13560-3-sachin.saxena@oss.nxp.com> References: <20200928085713.13560-1-sachin.saxena@oss.nxp.com> <20200928085713.13560-3-sachin.saxena@oss.nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/dpaa2: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/09/2020 10:57, Sachin Saxena (OSS): > + /* With new implementation of .close, port private data > + * will also be release by close callback. > + */ > dpaa2_dev_close(eth_dev); I think this comment is weird.