From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/bonding: fix link status check
Date: Tue, 06 Feb 2018 21:52:48 +0100
Message-ID: <7290841.LMfcIyB1JH@xps>
References: <20171129145349.43448-1-tomaszx.kulasek@intel.com>
 <20171129154200.14436-1-tomaszx.kulasek@intel.com>
 <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 Tomasz Kulasek <tomaszx.kulasek@intel.com>
To: declan.doherty@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1B1C41B415
 for <dev@dpdk.org>; Tue,  6 Feb 2018 21:52:53 +0100 (CET)
In-Reply-To: <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/01/2018 17:02, Ferruh Yigit:
> On 11/29/2017 3:42 PM, Tomasz Kulasek wrote:
> > Some devices needs more time to initialize and bring interface up. When
> > link is down the link properties are not valid, e.g. link_speed is
> > reported as 0 and this is not a valid speed for slave as well as for whole
> > bonding.
> > 
> > During NIC (and bonding) initialization there's concurrency between
> > updating link status and adding slave to the bonding.
> > 
> > This patch:
> > 
> >  - adds delay before configuring bonding (if link is down) to be sure that
> >    link status of new slave is valid,
> >  - propagates information about link status from first slave with link up
> >    instead of first slave at all, to be sure that link speed is valid.
> > 
> > Fixes: 6abd94d72ab5 ("net/bonding: fix check slaves link properties")
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> > ---
> > v2 changes:
> >  - Checkpatch warnings,
> >  - Improved code style
> Hi Declan,
> 
> Any comment on this patch?

Any news?