From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhao, Bing" <ilovethull@163.com>
Subject: Re: [PATCH] vhost: fix dequeue zero copy not work with
 virtio1
Date: Wed, 20 Dec 2017 13:58:22 +0800
Message-ID: <7304a91b-468c-ccaf-83ab-e1d74bb37500@163.com>
References: <1513183856-5639-1-git-send-email-junjie.j.chen@intel.com>
 <90d47113-c379-8523-2eab-671a15e59de2@redhat.com>
 <74F120C019F4A64C9B78E802F6AD4CC278E577C9@IRSMSX106.ger.corp.intel.com>
 <20171215124804.GB2439@yliu-mob>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: "Chen, Junjie J" <junjie.j.chen@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Loftus, Ciara" <ciara.loftus@intel.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Return-path: <dev-bounces@dpdk.org>
Received: from m50-135.163.com (m50-135.163.com [123.125.50.135])
 by dpdk.org (Postfix) with ESMTP id E5238160
 for <dev@dpdk.org>; Wed, 20 Dec 2017 06:58:28 +0100 (CET)
In-Reply-To: <20171215124804.GB2439@yliu-mob>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2017/12/15 20:48, Yuanhan Liu wrote:
> On Fri, Dec 15, 2017 at 10:33:41AM +0000, Loftus, Ciara wrote:
> >>
> >> Hi Junjie,
> >>
> >> On 12/13/2017 05:50 PM, Junjie Chen wrote:
> >>> This fix dequeue zero copy can not work with Qemu
> >>> version >= 2.7. Since from Qemu 2.7 virtio device
> >>> use virtio-1 protocol, the zero copy code path
> >>> forget to add offset to buffer address.
> >>>
> >>> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> >>> ---
> >>>    lib/librte_vhost/virtio_net.c | 3 ++-
> >>>    1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> >>> index 6fee16e..79d80f7 100644
> >>> --- a/lib/librte_vhost/virtio_net.c
> >>> +++ b/lib/librte_vhost/virtio_net.c
> >>> @@ -977,7 +977,8 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct
> >> vhost_virtqueue *vq,
> >>>                        desc->addr + desc_offset,
> >> cpy_len)))) {
> >>>                cur->data_len = cpy_len;
> >>>                cur->data_off = 0;
> >>> -            cur->buf_addr = (void *)(uintptr_t)desc_addr;
> >>> +            cur->buf_addr = (void *)(uintptr_t)(desc_addr
> >>> +                + desc_offset);
> >>>                cur->buf_iova = hpa;
> >>>
> >>>                /*
> >>>
> >>
> >> Thanks for fixing this.
> >>
> >> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >>
> >> Maxime
> >
> > Thanks for the fix. Can this be considered for the stable branch?
>
> Yes, I think so. Applied to dpdk-next-virtio, with
>
> Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
> Cc: stable@dpdk.org
>
> Thanks.
>
>     --yliu
>
@Yuanhan & Maxime, sorry to interrupt here. I meet the same issue recently. Could the "cur->data_off" field be used here with the value "desc_offset"? (I don't go through all the code and am a little confused about the "0". Is there any detail description about the "data_off" field?)
Thanks