From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 01/13] port: added structures for port stats Date: Mon, 18 May 2015 12:47:44 +0200 Message-ID: <7306400.tIjx29JTOm@xps13> References: <1430395652-6852-1-git-send-email-michalx.k.jastrzebski@intel.com> <1430395652-6852-2-git-send-email-michalx.k.jastrzebski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Maciej Gajdzica Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 0101BC382 for ; Mon, 18 May 2015 14:29:44 +0200 (CEST) Received: by wizk4 with SMTP id k4so77128598wiz.1 for ; Mon, 18 May 2015 05:29:43 -0700 (PDT) In-Reply-To: <1430395652-6852-2-git-send-email-michalx.k.jastrzebski@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-04-30 14:07, Michal Jastrzebski: > From: Maciej Gajdzica [...] > struct rte_port_out_ops { > - rte_port_out_op_create f_create; /**< Create */ > - rte_port_out_op_free f_free; /**< Free */ > - rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > - rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > - rte_port_out_op_flush f_flush; /**< Flush */ > + rte_port_out_op_create f_create; /**< Create */ > + rte_port_out_op_free f_free; /**< Free */ > + rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > + rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > + rte_port_out_op_flush f_flush; /**< Flush */ > + rte_port_out_op_stats_read f_stats; /**< Stats */ > }; Please avoid changing alignment if not really necessary. Here it seems you want to have some space between "f_stats;" and its comment. So you should use spaces for alignment of the comments and not hard-tabs, even less hard-tabs used as 4-char like here.