From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] kni: return failure for all ioctls
Date: Tue, 02 Oct 2018 17:55:21 +0200
Message-ID: <73277529.Xa667ZQCeR@xps>
References: <20180913214652.20771-1-dg@adax.com>
 <ae736e9c-7778-2ea6-8ee2-a000e3f8afd9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Dan Gora <dg@adax.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 99CC45F21
 for <dev@dpdk.org>; Tue,  2 Oct 2018 17:55:23 +0200 (CEST)
In-Reply-To: <ae736e9c-7778-2ea6-8ee2-a000e3f8afd9@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/09/2018 18:19, Ferruh Yigit:
> On 9/13/2018 10:46 PM, Dan Gora wrote:
> > Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead
> > of 0.
> > 
> > This is necessary because the Wicked (and possibly other) network
> > interface managers will perform the SIOCGIWNAME ioctl to check if
> > the interface is a wireless interface.  If the KNI module returns
> > success, Wicked will incorrectly interpret the interface as a wireless
> > interface.
> > 
> > Signed-off-by: Dan Gora <dg@adax.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks