From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 00/21] Support flow director programming on Fortville Date: Mon, 27 Oct 2014 16:22:38 +0100 Message-ID: <7329264.iY5QxnAQDU@xps13> References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Jingjing Wu Return-path: In-Reply-To: <1413939687-11177-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-22 09:01, Jingjing Wu: > The patch set supports flow director on fortville. > It includes: > - set up/tear down fortville resources to support flow director, such as queue and vsi. > - support operation to add or delete 8 flow types of the flow director filters, they are ipv4, tcpv4, udpv4, sctpv4, ipv6, tcpv6, udpv6, sctpv6. > - support flushing flow director table (all filters). > - support operation to get flow director information. > - match status statistics, FD_ID report. > - support operation to configure flexible payload and its mask > - support flexible payload involved in comparison and flex bytes report. > > v2 changes: > - create real fdir vsi and assign queue 0 pair to it. > - check filter status report on the rx queue 0 > > v3 changes: > - redefine filter APIs to support multi-kind filters > - support sctpv4 and sctpv6 type flows > - support flexible payload involved in comparison > > v4 changes: > - strip the filter APIs definitions from this patch set > - extend mbuf field to support flex bytes report > - fix typos Previous version was acked by Chen Jing D(Mark) and Helin Zhang. Have they reviewed the v4? I won't review neither i40e nor testpmd parts in detail. I prefer focusing on API (mbuf and ethdev) for my review. -- Thomas